add pangram tests #228
add pangram tests #228
Conversation
|
Missing the tests that states that numbers are allowed in a pangram. Such as "The quick brown fox jumped over the lazy dog for another 5 points." The number not invalidating the pangram. Neither does the capital T, nor the period. The concern given before was 26 unique characters passing. That test seems to also be missing. |
We have one test case for
I think you are referencing exercism/ruby#294, but its about not passing with 26 unique word characters, which the latter two tests address. Checking for 26 unique characters would fail at |
|
I guess @victorbrenders PR is not being used, so I guess it doesn't matter what his intention was. My response may have been in confusion with the now split concerns between two tests that may be meant to cover the same problem. The test should be a pangram that has numbers, and it should ensure that it can pass. This is esting that if you are missing the 't' 'i' and 'o' it will fail. The numbers, again, are a distraction to what the test should be testing. We already have a test for missing letters. We don't have a test for pangram phrases that have numbers in them. I think we should. It also may be possible that a test should exist where you have `0123456789klmnopqrstuvwxyz' which is 26 unique (Regular Expression) word (class) characters. I think that @victorbrender was stating that there was a solution he had seen that would have had that pass based on a regular expression word class solution, and I think it was what his test was meant to test for. Though unsure, he has yet to confirm his intent. |
|
I talked with @kotp and made some changes based on his feedback. |
| { | ||
| "description": "pangram with numbers", | ||
| "input": "the 1 quick brown fox jumps over the 2 lazy dogs", | ||
| "expected": false |
There was a problem hiding this comment.
should this be true, since it has all letters a-z? The presence of extra numbers should not cause the expected result to be false, right?
|
Ugh, bad copy paste job. |
|
@petertseng updated my derp error. Thanks for catching that. I meant to copy over "the quick brown fox..." but copied "the quick brown fish..." by mistake. Corrected the "fish" part and forgot about the expectation 😿 |
this commit adds 4 total tests 1 non-pangram to resolve #222 (comparison to "abc...") 2 pangram with underscores 3 pangram with numbers 4 non-pangram where missing letters are replaced by numbers 2 and 4 are designed to fail solutions that rely on counting the number of word characters (which include numbers and underscore) 3 is intended to clarify that numbers are allowed in a pangram and thus their mere presence in 4 is not the cause of a failure
|
Squashed commits. |
|
@exercism/track-maintainers Don't forget to generate pangram tests for your track. |
add missing test to sum-of-multiples exercise
this commit adds 3 total tests
the latter two are designed to detect solutions that rely on counting
the number of word characters (which include numbers and underscoe)