Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create canonical data for ledger, lifted from the Python tests #2287

Merged
merged 4 commits into from Jun 25, 2023
Merged

Create canonical data for ledger, lifted from the Python tests #2287

merged 4 commits into from Jun 25, 2023

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jun 10, 2023

No description provided.

ErikSchierboom
ErikSchierboom reviewed Jun 11, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I've left some minor comments

exercises/ledger/canonical-data.json Outdated Show resolved Hide resolved
exercises/ledger/canonical-data.json Show resolved Hide resolved
exercises/ledger/canonical-data.json Outdated Show resolved Hide resolved
@IsaacG IsaacG added x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) labels Jun 11, 2023
@BethanyG BethanyG removed their request for review June 16, 2023 02:31
IsaacG and others added 4 commits June 23, 2023 13:44
kotp
kotp approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

kytrinyx
kytrinyx approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kotp kotp merged commit 7f765dd into exercism:main Jun 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp approved these changes

@kytrinyx kytrinyx kytrinyx approved these changes

@glennj glennj Awaiting requested review from glennj

@junedev junedev Awaiting requested review from junedev

@siebenschlaefer siebenschlaefer Awaiting requested review from siebenschlaefer

@wolf99 wolf99 Awaiting requested review from wolf99

@ErikSchierboom ErikSchierboom Awaiting requested review from ErikSchierboom

@MatthijsBlom MatthijsBlom Awaiting requested review from MatthijsBlom

Assignees
No one assigned
Labels
x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IsaacG @kotp @ErikSchierboom @kytrinyx @MatthijsBlom