Clarify handling scores greater than 255 in allergies.

[jtigger]

No description provided.

[jtigger]

Addresses #224.

Expressed in solution-agnostic terms.

[IanWhitney]

Just to make sure I understand, this change would mean that a test of 257 would be allergic to all the items mentioned in the readme?

[NobbZ]

As I understand it the read me asks for a simple modulo equivalency.

Ian Whitney notifications@github.com schrieb am Sa., 1. Okt. 2016 14:56:

Just to make sure I understand, this change would mean that a test of 257
would be allergic to all the items mentioned in the readme?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#389 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADmR-EheimSoR6rCyKArw5q2QxulUYxks5qvliUgaJpZM4KLn79
.

[Insti]

257 would mean allergic to eggs (1)

[jtigger]

The modification of the description plus the final test in suite implied by the canonical-data.json would mean that a score of 257 would mean some uncodified allergen (256) plus eggs(1), the former to be ignored/masked/modulo'ed.

[IanWhitney]

Ok. That's not how this change reads for me.

Note: a given score may include allergens not listed above (i.e. allergens that score 256, 512, 1024, etc.). Your program should ignore those components of the score

The "ignore those components" could be clearer. Maybe:

Note: Allergens with higher scores (i.e., 256, 512, 1024) should be ignored. For example, a score of 257 would be allergic to just Eggs.

[jtigger]

Added example to the description. Thanks, @IanWhitney.

[kytrinyx]

This looks good to me. Thanks for hashing out the details on this!