Clarify that in Python there is a week descriptor called 'fifth' #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
BethanyG
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Thank you for this! I've suggested a little rephrase, and edited to conform to our 'one sentence per line' formatting rule.
Absolutely fine if you don't like/accept the suggested rephrase.
|
Once you've looked this over (and approve or not), I will merge. 😄 |
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clarification to the docs that in Python there is a week descriptor called
fifththat should be the fifth weekday of the month, if one exists.