Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transpose & generate_tests.py]: Added join env Function & Changed Template #3760

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

BethanyG
Copy link
Member

As a result of the discussion here in the forum and the previously logged issue here in GitHub, decided to alter the JinJa2 template for this exercise, so that the test case input was "pre joined" prior to verifying it in the test case.

This is to avoid any ambiguity around whether the function input is intended to be a list or a str (the intent from problem specs is that the inputs are strs).

[x] Changed generate_tests.py to add the join_test_inputs() function & make it available in the template environment.
[x] Changed the JinJa2 template to use the pre-join functionality, and to preserve the \n characters.
[x] Changed the stub to reflect renaming lines to text for the input parameter.
[x] Regenerated a new test file & tested example.py against it.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@BethanyG BethanyG merged commit 7ea631f into exercism:main Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant