Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generators: Default test template #572

Merged
merged 9 commits into from
Apr 28, 2017
Merged

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Apr 27, 2017

Description

Update generator logic so it uses a default test template if an exercise does not have example.tt.

Motivation and Context

Most of the generators now use a consistent template. The variations that used to exist were a result of inconsistent naming and/or putting logic in views. Providing a fallback default template should encourage generator authors not to put logic in the templates.

I chose this out of the open generator improvement issues (#485) as I'm trying to reduce the complexity of writing a new generator.

How Has This Been Tested?

New functionality has unit tests
I also manually conducted integration tests

  • removed example.tt from an exercise, regenerated the test file; no changes
  • regenerated the test file for an exercise with example.tt; no changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

References and Closures

#485

Checklist:

  • My change requires a change to the documentation.
  • My change relies on a pending issue/pull request
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kotp kotp merged commit faa3286 into exercism:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants