generators: Remove non custom templates #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
exercises/<whatever>/example.ttwhen it has no changes fromlib/generator/test_template.erb. In this PR I'm only removing 'custom' templates for exercises which are already using (or essentially using) the default templatesFor those interested in stats, after this PR, 26 of 38 generators use the default template. Many more could also use the default template, however, converting them is beyond the scope of this PR.
Motivation and Context
Removing the unnecessary
example.ttis cleanup post #572 and prep for moving all exercise metadata under.metaHow Has This Been Tested?
After removing each file, I regenerate the test for the exercise and use git to check that using the default creates no changes.
Types of changes
Cleanup. (This ought to be a type in the list!)
References and Closures
#572
Checklist:
My change requires a change to the documentation.My change relies on a pending issue/pull requestI have updated the documentation accordingly.I have added tests to cover my changes.