Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[C#] Simplify Enums exercise #663

Closed
ErikSchierboom opened this issue Feb 12, 2020 · 5 comments
Closed

[C#] Simplify Enums exercise #663

ErikSchierboom opened this issue Feb 12, 2020 · 5 comments
Assignees
Labels
status/in-progress This issue is being worked on track/csharp type/improve-exercise Improve an existing exercise

Comments

@ErikSchierboom
Copy link
Member

The Enums Concept Exercise requires parsing a string into a user-defined enum. The idiomatic way to do that is through Enum.Parse, which makes the generics a prerequisites. As enums are a very core data type, we feel that the generics prerequisite is a bit harsh, and that should be moved to the Advanced Enums Concept Exercise.

One benefit of this, is that enums can be used in other “simpler” exercise, without having the generics prerequisite. Another benefit would be that we can introduce the switch statement in the Enums Concept Exercise, as it is perfect for use together with enums.

In summary, the following changes should be made:

  • The parsing requirement should be dropped from the Enums exercise, which means that generics won't be a prerequisite anymore.
  • The Enums exercise should be redesigned to also lead the student towards using a switch in the implementation (note that a reference to the switch statement should be added to the introduction.md document).
  • The Enums Advanced exercise should be redesigned to require parsing an enum. It should thus also add the generics` Concept as prerequisites.
@ErikSchierboom ErikSchierboom added status/help-wanted Extra attention is needed track/csharp type/improve-exercise Improve an existing exercise labels Feb 12, 2020
@batibot323
Copy link
Contributor

I'm all for this!

@ErikSchierboom ErikSchierboom added status/in-progress This issue is being worked on and removed status/help-wanted Extra attention is needed labels Feb 12, 2020
@iabdelkareem
Copy link

I can pick this one as my first contribution ^^

@ErikSchierboom
Copy link
Member Author

@iabdelkareem I'm sorry, but this issue has already been assigned to @batibot323 (hence its status status/in-progress. You can look for open issues here: https://github.com/exercism/v3/issues?q=is%3Aissue+is%3Aopen+label%3Atrack%2Fcsharp+label%3Astatus%2Fhelp-wanted

@iabdelkareem
Copy link

@ErikSchierboom my bad sorry didn't notice that ^^

@ErikSchierboom
Copy link
Member Author

@iabdelkareem No problem! It's fantastic that you want to help. We'll be opening lots of new issues that you can help with over the next couple of weeks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/in-progress This issue is being worked on track/csharp type/improve-exercise Improve an existing exercise
Projects
None yet
Development

No branches or pull requests

4 participants