-
Notifications
You must be signed in to change notification settings - Fork 164
[Go] Concepts needed to solve the v2 two fer exercise #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side! Many valuable things to put into the concept exercises later in introduction.md
or in after.md
.
I'd leave this open for a few days so others can also review it |
### Linting | ||
|
||
It's the first time most students work with go, and many have not yet used `golint`. Linting already provides some hints | ||
on what (not) to do, eg use of variable names, not using else if the the regular condition ends with return, and missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite clear to me (what does 'use of variable names' mean? You should use them? You shouldn't use them?)
Co-Authored-By: Gabriel Nelle <tehsphinx@web.de>
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
1151d3d
to
c550f92
Compare
I rebased this so the link-checkers work now |
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Just as a side node: These And they will help us later to define the prerequisites of a practice exercise (v2 exercise) which in turn defines the tree of exercises that needs to be finished before a practice exercise will be unlocked. What these PRs are not for is to determine how to solve an exercise in an idiomatic way. It's not about right vs wrong, good vs bad, fast vs slow, etc. It's purely about which concepts are (commonly) used to solve this. |
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
solves #230