Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[Go] Concepts needed to solve the v2 two fer exercise #233

Merged
merged 13 commits into from
Jan 25, 2020
Merged

Conversation

hans-d
Copy link
Contributor

@hans-d hans-d commented Jan 21, 2020

solves #230

@hans-d hans-d requested a review from a team January 21, 2020 19:48
Copy link
Member

@tehsphinx tehsphinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side! Many valuable things to put into the concept exercises later in introduction.md or in after.md.

@tehsphinx
Copy link
Member

I'd leave this open for a few days so others can also review it

### Linting

It's the first time most students work with go, and many have not yet used `golint`. Linting already provides some hints
on what (not) to do, eg use of variable names, not using else if the the regular condition ends with return, and missing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite clear to me (what does 'use of variable names' mean? You should use them? You shouldn't use them?)

languages/go/reference/exercise-concepts/two-fer.md Outdated Show resolved Hide resolved
languages/go/reference/exercise-concepts/two-fer.md Outdated Show resolved Hide resolved
languages/go/reference/exercise-concepts/two-fer.md Outdated Show resolved Hide resolved
languages/go/reference/exercise-concepts/two-fer.md Outdated Show resolved Hide resolved
@tehsphinx
Copy link
Member

I rebased this so the link-checkers work now

Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
tehsphinx and others added 6 commits January 25, 2020 08:45
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
Co-Authored-By: Victor Goff <keeperotphones@gmail.com>
@tehsphinx
Copy link
Member

tehsphinx commented Jan 25, 2020

Just as a side node: These concepts needed for v2-issues (and PRs) are there to figure out which concepts exists to complete our list of concepts: https://github.com/exercism/v3/issues/167.

And they will help us later to define the prerequisites of a practice exercise (v2 exercise) which in turn defines the tree of exercises that needs to be finished before a practice exercise will be unlocked.

What these PRs are not for is to determine how to solve an exercise in an idiomatic way. It's not about right vs wrong, good vs bad, fast vs slow, etc. It's purely about which concepts are (commonly) used to solve this.

tehsphinx and others added 2 commits January 25, 2020 08:56
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
Co-Authored-By: John Arundel <john@bitfieldconsulting.com>
@kotp kotp merged commit bf158b0 into master Jan 25, 2020
@kotp kotp deleted the go-twofer-concepts branch January 25, 2020 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants