Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby/two-fer: Improve mentor notes #641

Merged
merged 9 commits into from Jan 5, 2019

Commits on Dec 2, 2018

  1. Group style suggestions

    Groups the suggestions about style together, so it's clear which suggestions are functional and which are not. Add links to the specific community style guide rules.
    SleeplessByte committed Dec 2, 2018
    Copy the full SHA
    7fb9921 View commit details
    Browse the repository at this point in the history
  2. Remove explicit module notion and make it a first class citizen

    At this point in the track it's fine to use ANYTHING, but the notion that "class" is somehow more correct than module is off-putting.
    
    A class should only be used if its functionality requires instantation. Utility functions and the sorts should either be on a named constant which is an Object, or a module so it can be included/extended and shared in other modules and classes.
    SleeplessByte committed Dec 2, 2018
    Copy the full SHA
    942078d View commit details
    Browse the repository at this point in the history
  3. Add more reasonable solutions including string templates.

    The point of this exercise is to prepare a student for the track, not force one usage over another.
    
    String interpolation is simpler, but template strings are much more maintainable when used with named arguments as it can be subtituted easily for internationalisation and/or extended.
    
    This adds all the variations as reasonable so mentors no longer penalise students for using it.
    SleeplessByte committed Dec 2, 2018
    Copy the full SHA
    e975431 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    5ae5a92 View commit details
    Browse the repository at this point in the history
  5. Remove bookkeeper suggestion

    I don't think this is still part of the actual implementation and thus does not need to be part of the mentor notes.
    SleeplessByte committed Dec 2, 2018
    Copy the full SHA
    999e169 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    1ce5412 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Change to use actual alternative

    `format` is being used in the example, so `sprintf` is the alternative to that
    SleeplessByte committed Dec 5, 2018
    Copy the full SHA
    0d80047 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    383b9e4 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    26f7b4b View commit details
    Browse the repository at this point in the history