-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the build system is messy, let's switch or fix. #62
Comments
Please could you put a bit less emotion in your postings? I tend to skip such items completely. |
Mavenizing the build should probably be not too large of an issue (as long no git *&^%^& submodules are used), but the blocker for a long long time is eXist-db/exist#2140 (the PR is written after more than a half year of work making many fixes in many places). This PR blocks quite some pending work for me, e.g. it does not allow me to work on a few XAR files for more than a year. |
@dizzzz still there are 6 remaining failures in that PR and unfortunately each is rather hard to fix. I've been working on it for a longer time. |
@dizzzz while i agree that the xqsuite PR is important, i don't see how it impacts the build over here. There is currently a single xqsuite unit test for monex that might be affected (it passes right now), java tests for console and remoteConsole as well as integrations tests are unaffected by 2140. |
@wolfgangmm thnx for the info! |
Addressed by #63 |
currently the build system requires a full local clone of exist (still pointing to wolfgangs develop clone), this seems all kinds of bad with respect to repeatable builds. There is also around 100
.jar
on the classpath for no discernible reason, other thenexist/**.jar
is quick to type.I've been able to wiggle these down to 5, but i m stomped by a build that runs on local yet throws weird java io ivy errors on ci. My attempts at mavenizing the build similarly have hit a wall. So hopefully others more deeply versed in ivy and maven for exist can help me out here.
This is the last of the default apps that doesn't sport a repeatable build, so whichever route ivy / maven we should fix this. Since monex is a showstopper for
5.0.0
we should switch the build system before or together with the required changes for the next major release.Ideally this improved build system should:
The text was updated successfully, but these errors were encountered: