Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Signature table refactoring (many issues) #679

Closed
exodus4d opened this issue Aug 31, 2018 · 0 comments
Closed

[Improvement] Signature table refactoring (many issues) #679

exodus4d opened this issue Aug 31, 2018 · 0 comments
Assignees
Milestone

Comments

@exodus4d
Copy link
Owner

The recent changed and new features added to the "signature module" made the client side code even more complex, more vulnerable for bugs and harder to maintain. Therefore I had to made a full refactoring/rewrite of the "signature module".

What should be achieved:

  • client side updates in the sig table are faster and less buggy
  • added support for simultaneous editing of the same signature by multiple users
  • reduced the amount of "self written code" and use more 3rd party code that is shipped with the JS libraries which are used
  • many more bug fixes

The main problem that should be solved:

There are two main JS libs in use for the sig table. For table render DataTables and xEditable for the inPlace editing stuff. DataTables uses an underlaying data object cache that holds all the cell data, and xEditable just handles the editing and save/update stuff for a cell.
The problem we had is, that updates made by xEditable were not made to the DataTables table cache as well and checking the table for updates required a full DOM scan looking for xEditables fields and their current value. -> bad performance.
No we need a two-way-binding where changes made to a cell, xEditable updates the DataTables cache. And changes made to the DataTables cache (e.g. auto table update) updates the xEditable value. This will made a lot things easier...

test

@exodus4d exodus4d added this to the v1.4.1 milestone Aug 31, 2018
@exodus4d exodus4d self-assigned this Aug 31, 2018
exodus4d added a commit that referenced this issue Aug 31, 2018
- improved "character info" tooltips in e.g. signature Table
- improved performance with the live time counters in e.g. signature table
- fixed a bug where mass delete signatures on a system sometimes failed
- fixed a bug where "signature type" sometimes not get saved correctly
- fixed a bug where "responsive table columns" were not shown on larger screens
@exodus4d exodus4d mentioned this issue Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant