This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
Hide controller ray when in orbit controls mode #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge in fork master
After testing again, this definitely needs to be covered, because having the ray appear when mouse moves outside of viewport is very annoying. |
chrislatorres
commented
Jun 9, 2019
avaer
pushed a commit
that referenced
this pull request
Aug 5, 2019
Hide controller ray when in orbit controls mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #5 this PR hides the controller ray when in orbit controls mode.
This PR is may not be complete yet though because the rays appear when the mouse cursor leaves the viewport and orbit controls is not present.