Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience methods to Stranded #22

Conversation

ielis
Copy link
Collaborator

@ielis ielis commented Dec 17, 2020

@julesjacobsen I propose adding default methods toPositiveStrand() and toNegativeStrand() to Stranded.

These methods would allow us to write a code that is easier to read. E.g.:

Variant variant = ...
GenomicRegion region = variant.toPositiveStrand().toZeroBased();

instead of current

Variant variant = ...
GenomicRegion region = variant.withStrand(Strand.POSITIVE).toZeroBased();

Please feel free to merge the PR if you agree.

@ielis ielis added the enhancement New feature or request label Dec 17, 2020
@julesjacobsen julesjacobsen merged commit ac3d912 into coordinate-systemed-region Dec 17, 2020
@ielis ielis deleted the enhancement/stranded_convenience_methods branch December 17, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants