Fix Travis Build #16
Merged
Fix Travis Build #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be restored in the corresponding PR
| 1. *desired* The algorithm should not give preferences for any nodes (or artificially decrease priority for other nodes). | ||
| In our case, we give preferences for nodes that were less involved in last `F` blocks. Perhaps such nodes do not give block proposals due to objective reasons: bad connection, server overloading, etc. | ||
| 2. *desired* Round Robin orders could be calculated strictly after the previous block was accepted. | ||
| # Leader Election |
There was a problem hiding this comment.
Why have you deleted the Leader Election part?
It's the file that was in repo since e238408
There was a problem hiding this comment.
I can restore it, but frankly speaking, it would not pass my review if it was being pulled into the repo right now. I would prefer to merge it in a separate PR with @VukW . To be honest, anchoring spec is only marginally better, but it's slightly more important, too.
[ci skip]
This was referenced May 18, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Travis build for the project fails for multiple reasons. This PR tries to fix that.