Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta tags (for the material theme) #43

Merged
merged 9 commits into from
Jun 13, 2017
Merged

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Jun 7, 2017

Alternative to #13, which is outdated because of a new docs theme.

Solves #10.

boguslavsky
boguslavsky previously approved these changes Jun 8, 2017
Copy link
Contributor

@boguslavsky boguslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as for ae00c68

@slowli @djsatok guys, how do you think, maybe it is make sense to also support Twitter's Summary Card or Summary Card with Large Image

This was referenced Jun 8, 2017
>= 2.8 needed for `equalto` test
May be temporary
@slowli
Copy link
Contributor Author

slowli commented Jun 8, 2017

Done. I didn't add twitter:image meta-tag because the Twitter documentation suggests that it should be unique for each page (and this tag is optional anyway). I don't think we should craft meta-tag images for specific pages, at least not now.

alexauroradev
alexauroradev previously approved these changes Jun 9, 2017
Copy link
Contributor

@alexauroradev alexauroradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It's possible to change a wallpaper

mkdocs.yml Outdated
extra:
og_image: 'images/wallpaper.png'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just leave here 'Symbol with wordmark' from http://exonum.com/press-kit.html ? The part of the image on first page is a little bit ugly, as for me.

Copy link
Contributor

@alexauroradev alexauroradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slowli slowli merged commit 0ce8a4e into exonum:master Jun 13, 2017
@slowli slowli deleted the add-meta-tags branch June 13, 2017 12:48
@slowli slowli mentioned this pull request Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants