-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible method for isobaric slice plotting #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the plotting routines. They give an easy to use first quick and dirty plotting feeling!
I think that (apart from the comments) they are not even very restrictive.
One fundamental design choice for the plotting routines would be the question of weither we want the gcmt object to become a member of the Plotting class. A benefit of that could be that you could just select a tag to plot.
What do you think?
Co-authored-by: Aaron David Schneider <aaron.schneider@nbi.ku.dk>
Do you mean whether to do something like |
How about having both? E.g. and then drop the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! I have two very small comments
Co-authored-by: Aaron David Schneider <aaron.schneider@nbi.ku.dk>
Co-authored-by: Aaron David Schneider <aaron.schneider@nbi.ku.dk>
Thanks @robinbaeyens! |
I made the first plotting method, i.e. isobaric slice plotting.
I hope it is flexible enough to build other -- more specific -- plotting methods on it. Let me know what you think @AaronDavidSchneider
ps: first pull request in my life, yay!