exo sshkey delete --all #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
2 tasks
mcorbin
previously requested changes
Jan 22, 2019
cmd/sshkey_delete.go
Outdated
| return err | ||
| } | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, err) //nolint: errcheck |
There was a problem hiding this comment.
You should move this line in the previous if err != nil block.
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
greut
reviewed
Jan 23, 2019
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| fmt.Println(res) | ||
| //XXX Create a function to execute non async tasks asynchronousely |
added 3 commits
January 23, 2019 16:26
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
mcorbin
reviewed
Jan 29, 2019
| if err := deleteSSHKey(sshkey.Name); err != nil { | ||
| return err | ||
| } | ||
| fmt.Println(sshkey.Name) |
There was a problem hiding this comment.
nitpick: it could be nice to have a message like successfully deleted key <key_name>.
There was a problem hiding this comment.
that wouldn't be consistent though.
mcorbin
approved these changes
Jan 29, 2019
|
thanks @mcorbin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete all sshkey in a single command