Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sync Tasks async #89

Merged
merged 8 commits into from
Jan 31, 2019
Merged

Make sync Tasks async #89

merged 8 commits into from
Jan 31, 2019

Conversation

pierre-emmanuelJ
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ commented Jan 21, 2019 •
edited by greut
Loading

@pierre-emmanuelJ pierre-emmanuelJ added the enhancement New feature or request label Jan 21, 2019
greut
greut reviewed Jan 23, 2019
View reviewed changes
cmd/request.go Outdated
return
}

<-sem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the goal of this semaphore?

@pierre-emmanuelJ pierre-emmanuelJ mentioned this pull request Jan 25, 2019
Closed
2 tasks
Yoan Blanc and others added 6 commits January 29, 2019 13:20
request: using spinning loaders
00c1729 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
request: make them spin
a80c5f8 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
mod: use upstream mpb
ec715dd 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@pierre-emmanuelJ
Sync tasks async
e788089 
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
@pierre-emmanuelJ
Example with firewall create
e686278 
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
@pierre-emmanuelJ
Add asyncTasks() generic for egoscale.Command
ecaa2c7 
Signed-off-by: Pierre-Emmanuel Jacquier <pierre-emmanuel.jacquier@epitech.eu>
@greut
Copy link
Contributor

greut commented Jan 29, 2019

https://asciinema.org/a/vQ93BU0jBtHcYFinNz7gaI89s

@greut
Copy link
Contributor

greut commented Jan 29, 2019 •
edited
Loading

@pierre-emmanuelJ do you mind taking a look to have the elapsed time / done information?

@pierre-emmanuelJ
Copy link
Member Author

@pierre-emmanuelJ do you mind taking a look to have the elapsed time / done information?

Do you think this information can be added in egoscale for async request, and for sync request what do you think? Maybe can be same for sync request.

@greut
Copy link
Contributor

greut commented Jan 29, 2019

@pierre-emmanuelJ what's there basically. https://github.com/vbauerster/mpb/blob/master/examples/spinner/main.go

@pierre-emmanuelJ
Copy link
Member Author

cli/cmd/sos_upload.go

Line 160 in 8a6e801

decor.OnComplete(decor.AverageETA(decor.ET_STYLE_GO), "done!"),

@pierre-emmanuelJ
Copy link
Member Author

pierre-emmanuelJ commented Jan 29, 2019 •
edited
Loading

But sorry my reply was more about: do you think it's possible in egoscale or cloudstack to calculate "time left" for an async request.

@greut
Copy link
Contributor

greut commented Jan 29, 2019 •
edited
Loading

probably decor.Elapsed rather than ETA

Yoan Blanc added 2 commits January 30, 2019 07:24
dep: use mpb v4.0.x
696cdee 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
request: add elapsed time
6f5c126 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@pierre-emmanuelJ
Copy link
Member Author

👍

@greut greut merged commit 9753036 into master Jan 31, 2019
@greut greut deleted the synctask-async branch January 31, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greut greut greut left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierre-emmanuelJ @greut