Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: unify sync/async responses #110

Merged
merged 1 commit into from
Apr 30, 2018
Merged

global: unify sync/async responses #110

merged 1 commit into from
Apr 30, 2018

Conversation

greut
Copy link
Contributor

@greut greut commented Apr 30, 2018

Apply apache/cloudstack#2428

The trick is to marshal into a json.RawMessage with the drawback that is, almost, always works...

https://play.golang.org/p/2AAzw9YwFSr

@greut greut requested a review from marcaurele April 30, 2018 07:56
Copy link
Contributor

@marcaurele marcaurele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut greut merged commit 9ee6006 into master Apr 30, 2018
@greut greut deleted the success-success branch April 30, 2018 09:53
@greut greut mentioned this pull request May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants