batch constraints for DoE and __call__ for interpointEqualityConstraint #322
Conversation
Osburg
changed the title
| ], | ||
| ) | ||
| def test_constraints_call(constraints, num_candidates): | ||
| candidates = inputs.sample(num_candidates, SamplingMethodEnum.UNIFORM) | ||
| returned = constraints(candidates) | ||
| assert returned.shape == (num_candidates, len(constraints)) | ||
|
|
||
| num_rows = 0 |
There was a problem hiding this comment.
Are we anywhere testing that the call method returns the correct values? We need to urgently refactor our tests :D
There was a problem hiding this comment.
At least I haven't found them :D But added one testing if the design generation works with batch constraints.
|
Weird that the test |
|
Just ignore it, this is due to randomness ... |
| x1 = np.round(result["x1"].values, 6) | ||
|
|
||
| assert 0 in x1 and 1 in x1 | ||
| for i in range(10): |
There was a problem hiding this comment.
you could just call domain.validate_candidates(result, only_inputs=True) in the test. This is also doing the check.
yes, please go ahead |
This PR adds a call method for batch constraints as discussed in #313 and adds support for batch constraints /
InterpointEqualityConstraintin DoE as discussed in #310. Closes #310