Make batch_limit and maxiter configurable

[jduerholt]

This PR implements the following:

• make batch_limit and maxiter which are optimizer hyperparams for botorch based strategies configurable in the data model
• move num_sobol_samples from the strategy data model to acqusition function data model as it is a parameter of the acqf.

[bertiqwerty]

Thanks, Johannes. Just a few minor comments.

[bertiqwerty]

Why did you add a parameter via inheritance? I would just put the parameter there. As in the case of alpha. If you really want to gather the MCAcquisitionFunction parameters somehow because you expect to add more parameters to MCAcquisitionFunction in the near future, at least do it via aggregation.

[jduerholt]

Hmm, why not adding the param via inheritance? And what do you mean by aggregation?

[bertiqwerty]

I personally think we should keep the code as simple as possible. Currently, I think, it is hard to read. You look at the data model and want to see the parameters. But there are none. I very often have a hard time to find the class that actually implements the functionality I am looking for in BoFire due to its deep inheritance hierarchy. Ok, readability is subjective.

With aggregation I meant composition. I would only use inheritance if I want to make use of polymorphism but not just to save some characters. I consider it good practice in object oriented programming to favor composition over inheritance. https://en.wikipedia.org/wiki/Composition_over_inheritance

Btw. I really like this talk 😁
https://learn.microsoft.com/en-us/shows/goingnative-2013/inheritance-base-class-of-evil (careful, it is C++)

[jduerholt]

Hmm, I prefer the inheritance :D

But I will change it and add it as attribute to every class.

Best,

Johannes

[bertiqwerty]

Hmm, I prefer the inheritance :D

I know 😉