Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LLaMA2 #263

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Add support for LLaMA2 #263

merged 3 commits into from
Jul 26, 2023

Conversation

danieldk
Copy link
Contributor

Description

LLaMA2 support different number of query and key-value heads. Also add new models to test k-n and k-1 head configurations.

Types of change

Feature

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

LLaMA2 support different number of query and key-value heads. Also add
new models to test k-n and k-1 head configurations.
@danieldk danieldk added type/feature Type: Feature feat/model Feature: models labels Jul 26, 2023
Copy link
Collaborator

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally, but we need to increment the transformers pin in the CI.

EDIT: We'll also need to add a separate generator for the chat models as they need custom prompting.

@danieldk danieldk merged commit 2abc7a6 into explosion:main Jul 26, 2023
7 checks passed
@danieldk danieldk deleted the feature/llama2 branch July 26, 2023 15:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/model Feature: models type/feature Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants