Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detox): Add optional Test Butler setup #147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhmiles
Copy link

@mhmiles mhmiles commented Nov 19, 2022

Why

I wanted to enable Test Butler with Detox on Android. This requires modification of some of the same files/lines as @config-plugins/detox so I was not able to develop the change as a separate package.

How

Added new option to @config-plugins/detox: includeTestButler

Setting this option to true will include the test library in app/build.gradle and make the necessary modifications to the test runner to engage Test Butler.

Test Plan

I have tested this locally by building and using it within my own app. Testing requires utilizing this change with includeTestButler set to true and downloading the Test Butler APK:

curl -f -o ./test-butler-app.apk https://repo1.maven.org/maven2/com/linkedin/testbutler/test-butler-app/2.2.1/test-butler-app-2.2.1.apk

and installing it with Detox.

@mhmiles mhmiles changed the title feat(detox): Add optional Test Butler setup in @config-plugins/detox feat(detox): Add optional Test Butler setup Nov 19, 2022
@mhmiles mhmiles marked this pull request as draft November 19, 2022 01:18
@mhmiles mhmiles marked this pull request as ready for review December 2, 2022 18:05
Copy link
Collaborator

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants