fix(ffmpeg-kit-react-native): fix Android build errors caused by duplicate libc++_shared.so #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #31.
The root cause of this is the issue described in the ffmpeg-kit docs:
This is currently breaking our build, so we're using
patch-package
to apply this diff.How
Using expo/expo#15863, which allows us to define a
android.packagingOptions.pickFirsts
property ingradle.properties
.Note that this currently doesn't check if there are any other
android.packagingOptions.pickFirsts
properties - I'm not even sure what the behavior should be in general (should it be replaced, appended, ...?).Test Plan
So far, this has only been tested by building our app on EAS, using
patch-package
to update thepackages/ffmpeg-kit-react-native/build/withAndroidFFMPEGPackage.js
file.Before: the
gradlew
task fails with the following error:After: build succeeds.