Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native-branch): Re-init branch session when resumed from background #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morgan-cromell
Copy link

Why

The react-native-branch plugin used the OnCreate lifecycle hook to call RNBranchModule.InitSession. This caused the session to only be initialized on first start of the application and not when switching from foreground to background.

How

According to the official docs you should use the OnStart hook to intialize Branch, but as this does not exists on ReactActivityLifecycleListener onResume was the closest one.

Test Plan

Tried to send an event to branch from react-native with

const event = new BranchEvent('TEST');
event.logEvent();

I used Android studio to monitor network traffic and see that the event is sent to Branch.

Before this fix this stopped working if the app was sent to the background and later resumed.

@jvgeee
Copy link

jvgeee commented Jun 26, 2024

Can this be merged in please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants