fix(react-native-branch): Re-init branch session when resumed from background #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The react-native-branch plugin used the
OnCreate
lifecycle hook to callRNBranchModule.InitSession
. This caused the session to only be initialized on first start of the application and not when switching from foreground to background.How
According to the official docs you should use the
OnStart
hook to intialize Branch, but as this does not exists onReactActivityLifecycleListener
onResume
was the closest one.Test Plan
Tried to send an event to branch from react-native with
I used Android studio to monitor network traffic and see that the event is sent to Branch.
Before this fix this stopped working if the app was sent to the background and later resumed.