Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-9927][eas-cli] add profile flag to eas build:run command #2035

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Aug 31, 2023

Why

https://linear.app/expo/issue/ENG-9927/add-support-for-e-profile-to-eas-buildrun

How

Add --profile flag. If the --profile flag is present filter using it.

Test Plan

Tested manually

@linear
Copy link

linear bot commented Aug 31, 2023

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Size Change: +442 B (0%)

Total Size: 42.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.3 MB +442 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fea7913) 54.21% compared to head (c14d032) 54.20%.

Files Patch % Lines
packages/eas-cli/src/commands/build/run.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   54.21%   54.20%   -0.00%     
==========================================
  Files         509      509              
  Lines       18657    18659       +2     
  Branches     3740     3741       +1     
==========================================
  Hits        10113    10113              
- Misses       8523     8525       +2     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the @szdziedzic/add-profile-flag-to-build-run-command branch from 424418f to ca4ad69 Compare November 14, 2023 16:54
@szdziedzic szdziedzic marked this pull request as ready for review November 14, 2023 17:08
@szdziedzic
Copy link
Member Author

/changelog-entry new-feature Add --profile flag to eas build:run command

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 7c48b2b into main Nov 15, 2023
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/add-profile-flag-to-build-run-command branch November 15, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants