[eas-cli] [ENG-10334] Display device creation date #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new field to gql type to fetch it later See: https://linear.app/expo/issue/ENG-10334/show-creation-time-of-device-record-in-ad-hoc-device-selection-prompt
Generated a new graphql schema based on updated local version of www See: https://linear.app/expo/issue/ENG-10334/show-creation-time-of-device-record-in-ad-hoc-device-selection-prompt
Fixed mutation that started to fail after schema update See: https://linear.app/expo/issue/ENG-10334/show-creation-time-of-device-record-in-ad-hoc-device-selection-prompt
Added creation date to the AppleDevice formatting function used to display details in cli See: https://linear.app/expo/issue/ENG-10334/show-creation-time-of-device-record-in-ad-hoc-device-selection-prompt
radoslawkrzemien
requested review from
szdziedzic and
khamilowicz
as code owners
ENG-10334 Show creation time of device record in ad hoc device selection prompt
gabriel just added a device, and I had multiple unselected devices listed and I had no idea which one was his. It would have been easy to determine if I saw when the device was registered. |
|
/changelog-entry chore Display Apple device creation date when listing devices |
|
Size Change: +387 B (0%) Total Size: 42.6 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
+ Coverage 54.07% 54.07% +0.01%
==========================================
Files 508 508
Lines 18669 18674 +5
Branches 3735 3934 +199
==========================================
+ Hits 10094 10097 +3
+ Misses 8554 7886 -668
- Partials 21 691 +670
|
Manually added the changelog entry since the automation failed for some reason See: https://linear.app/expo/issue/ENG-10334/show-creation-time-of-device-record-in-ad-hoc-device-selection-prompt
|
✅ Thank you for adding the changelog entry! |
szdziedzic
approved these changes
Oct 18, 2023
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-10334-display-device-creation-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-10334/show-creation-time-of-device-record-in-ad-hoc-device-selection-prompt
Companion of: https://github.com/expo/universe/pull/13641
How
Updated function formatting the display value of AppleDevice to include the creation date
Test Plan
Added automated tests
Deployment