Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] bump asset upload timeout from 90 to 180 seconds #2466

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

quinlanj
Copy link
Member

Why

Extend the timeout from 90 seconds to 180 seconds, because some people have really slow internet connections. Using a p99 of the cloud function time of 29s, we essentially change the upload timeout from 60s to 150s

background

Why we chose 90 seconds in the first place, from #2085:

For slow connections that take a while to upload, 60s is not enough of a timeout. For example, lets say there's only one asset to upload, and it takes even 1 second to upload and 60s to process (the max of the cloud function), it'll time out. The p99 of the processing cloud function is 29s, so changing this timeout to 90s gives a upload timeout of 60s.

We also change the semantics of when to reset the timeout, and now reset it when the upload is retried. So, in the example above, let's say the asset takes 59 seconds to upload, but fails at the 58th second, it will be retried and the timeout will reset to give it an additional 60 seconds to upload.

Test Plan

  • sanity check that eas update still works on a test project

@quinlanj quinlanj changed the title Temporary Commit at 7/19/2024, 1:39:06 PM [eas-cli] bump asset upload timeout from 90 to 180 seconds Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

Size Change: +45 B (0%)

Total Size: 52 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52 MB +45 B (0%)

compressed-size-action

@quinlanj
Copy link
Member Author

/changelog-entry chore bump asset upload timeout to 180 seconds

Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit aabe1ff into main Jul 22, 2024
3 of 6 checks passed
@quinlanj quinlanj deleted the @quin/extend-timeout branch July 22, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants