-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eas env:push and env:pull commands #2495
Add eas env:push and env:pull commands #2495
Conversation
11d0062
to
14c0704
Compare
Size Change: +7.6 kB (+0.01%) Total Size: 51.6 MB
|
14c0704
to
3633d6e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2495 +/- ##
==========================================
- Coverage 52.80% 52.59% -0.20%
==========================================
Files 545 548 +3
Lines 20223 20406 +183
Branches 4130 4163 +33
==========================================
+ Hits 10676 10731 +55
- Misses 8719 8835 +116
- Partials 828 840 +12 ☔ View full report in Codecov by Sentry. |
8f7a376
to
3ccc56f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The push/pull stuff generally looks good to me, I would remove all sudo utils as they are not needed anymore + move init ,load and unload to separate PR to not block merging the push and pull stuff
3ccc56f
to
9d7a177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, good job we are making really good progress here 🚀
b9570a9
to
be58276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this new env will need to be passed/used everywhere where buildProfile.env
is used:
eas-cli/packages/eas-cli/src/build/build.ts
Line 670 in be58276
env: ctx.buildProfile.env, |
env: buildProfile.env, |
eas-cli/packages/eas-cli/src/build/validate.ts
Lines 12 to 17 in be58276
if (ctx.buildProfile.env?.NODE_ENV === 'production') { | |
Log.warn( | |
'You set NODE_ENV=production in the build profile. Remember that it will be available during the entire build process. In particular, it will make yarn/npm install only production packages.' | |
); | |
Log.newLine(); | |
} |
env: ctx.buildProfile.env, |
env: buildProfile.env, |
env: ctx.buildProfile.env, |
const { exp, projectId } = await getDynamicPrivateProjectConfigAsync({ env: buildProfile.env }); |
env: buildProfile.env, |
env: buildProfile.env, |
env: buildProfile.env, |
env: profile.env, |
env: profile.env, |
const { exp, projectId } = await getDynamicPrivateProjectConfigAsync({ env: profile.env }); |
eas-cli/packages/eas-cli/src/commands/build/version/sync.ts
Lines 90 to 92 in be58276
const { exp, projectId } = await getDynamicPrivateProjectConfigAsync({ | |
env: profileInfo.profile.env, | |
}); |
env: profile.env, |
env: profile.env, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One general thing - I recommend using the Graphite tool to create stacked PRs (see how Will did it yesterday: https://app.graphite.dev/github/pr/expo/eas-cli/2505/chore-Add-typescript-linting-to-packages) vs putting 2-3 separate things:
- pull
- push
- using env vars
in one big PR.
This way we can iterate faster vs being blocked with a review process because 1 out of 3 things in big PR is not right yet.
We don't need to do this in this PR though, this is advice for the future.
be58276
to
e021f93
Compare
a229442
to
e17b83a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, good job 👏
e17b83a
to
ed27075
Compare
ed27075
to
546e27b
Compare
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This reverts commit 56510f0.
(Reopened #2437)
Why
User should be able to synchronise local environment variables with upstream.
How
eas env:pull
andeas env:push
commandseas env:pull
handles sudo access to request values of sensitive variablesTest Plan
Tested manually