[eas-json] add experimental.disableBundleIdValidation flag #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -656 B (0%) Total Size: 32.8 MB
|
wkozyra95
force-pushed
the
@wkozyra95/support-multiple-bundle-identifiers
branch
from
3a0ffd3
to
1ae4ed4
Compare
dsokal
reviewed
Mar 3, 2021
CHANGELOG.md
Outdated
| @@ -8,6 +8,8 @@ This is the log of notable changes to EAS CLI and related packages. | |||
|
|
|||
| ### 🎉 New features | |||
|
|
|||
| - add `experimental.disableBundleIdValidation` flag to eas.json ([#263](https://github.com/expo/eas-cli/pull/263) by [@wkozyra95](https://github.com/wkozyra95)) | |||
There was a problem hiding this comment.
Suggested change
| - add `experimental.disableBundleIdValidation` flag to eas.json ([#263](https://github.com/expo/eas-cli/pull/263) by [@wkozyra95](https://github.com/wkozyra95)) | |
| - Add `experimental.disableBundleIdValidation` flag to eas.json. ([#263](https://github.com/expo/eas-cli/pull/263) by [@wkozyra95](https://github.com/wkozyra95)) |
| @@ -102,6 +102,9 @@ const schemaBuildProfileMap: Record<string, Record<string, Joi.Schema>> = { | |||
| }; | |||
|
|
|||
| const EasJsonSchema = Joi.object({ | |||
| experimental: Joi.object({ | |||
| disableBundleIdValidation: Joi.boolean(), | |||
There was a problem hiding this comment.
Suggested change
| disableBundleIdValidation: Joi.boolean(), | |
| disableIosBundleIdValidation: Joi.boolean(), |
Maybe this is a better name to indicate this is for iOS.
| return { | ||
| builds: { | ||
| ...(androidConfig ? { android: androidConfig } : {}), | ||
| ...(iosConfig ? { ios: iosConfig } : {}), | ||
| ...(iosConfig ? { ios: { ...iosConfig, ...experimental } } : {}), |
There was a problem hiding this comment.
What if we add another field to the experimental object? I'd prefer explicitly choosing all relevant keys from the object.
There was a problem hiding this comment.
Or maybe we shouldn't merge it into the ios object, and instead, return an object of a similar structure as eas.json?
|
|
||
| const disableBundleIdValidation = (await new EasJsonReader(ctx.projectDir, 'all').readRawAsync()) | ||
| ?.experimental?.disableBundleIdValidation; | ||
| console.log(disableBundleIdValidation); |
There was a problem hiding this comment.
Suggested change
| console.log(disableBundleIdValidation); |
wkozyra95
force-pushed
the
@wkozyra95/support-multiple-bundle-identifiers
branch
from
1ae4ed4
to
7c82528
Compare
dsokal
approved these changes
Mar 3, 2021
brentvatne
approved these changes
Mar 3, 2021
wkozyra95
force-pushed
the
@wkozyra95/support-multiple-bundle-identifiers
branch
from
07ebddb
to
464fd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
https://linear.app/expo/issue/ENG-357/support-for-schemes-with-different-bundle-identifiers-in-generic-apps
How
experimental.disableBundleIdValidationis set then skip bundleIdedentifier validation or configurationTest Plan
build and build configure on https://github.com/brentvatne/myapp