feat: add previousValue to privacy policy context for updates #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 69
Lines 1892 1892
Branches 265 265
=========================================
Hits 1892 1892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ide
approved these changes
May 31, 2024
kitten
approved these changes
May 31, 2024
wschurman
force-pushed
the
@wschurman/can-delete-more-2
branch
from
02c338e
to
660f2fa
Compare
wschurman
force-pushed
the
@wschurman/can-delete-more-2
branch
from
660f2fa
to
b3ffa70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
One authorization evaluation case wasn't considered when building this context: when we want to allow a user to make a final update to an entity based on their permission from the value of the entity before the update, and then not allow them to make any further updates.
This PR adds previousValue to context for updates, somewhat like what we do for validators and triggers.
Closes ENG-12402.
Test Plan
Run tests (there's a test that looks for this value).