Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update comment #245

Closed
wants to merge 1 commit into from
Closed

chore: update comment #245

wants to merge 1 commit into from

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Jun 25, 2024

Why

Who knows

How

type it

Test Plan

testinprod.jpg

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

@wschurman wschurman marked this pull request as ready for review June 25, 2024 19:09
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (15117fc) to head (a2f09af).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         1949      1949           
  Branches       267       267           
=========================================
  Hits          1949      1949           
Flag Coverage Δ
integration 100.00% <ø> (ø)
unittest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman closed this Jun 26, 2024
@@ -3,7 +3,7 @@ import nullthrows from 'nullthrows';
import { ISecondaryEntityCache } from './EntitySecondaryCacheLoader';

/**
* A ISecondaryEntityCache that composes other ISecondaryEntityCache instances.
* A ISecondaryEntityCache that composes other ISecondaryEntityCache instances..
*/
export default class ComposedSecondaryEntityCache<TLoadParams, TFields>
implements ISecondaryEntityCache<TFields, TLoadParams>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Re: line 26]

comment outside code

See this comment inline on Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant