Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] expo-sqlite getAsync function reference #29085

Closed
HalilFocic opened this issue May 24, 2024 · 0 comments · Fixed by #29533
Closed

[docs] expo-sqlite getAsync function reference #29085

HalilFocic opened this issue May 24, 2024 · 0 comments · Fixed by #29533
Assignees
Labels

Comments

@HalilFocic
Copy link

Summary

In the withTransactionAsync example there is a function "getAsync" which is only referenced in that part of documentation.

The function executed should probably be getAllAsync" or getFirstAsync.

When i try to use getAsync in latest version of the expo-sqlite I get that the function doesn't exist.

This is probably a typo

Image for reference:
image

Link to the related docs page

https://docs.expo.dev/versions/latest/sdk/sqlite/

Anything else?

No response

amandeepmittal added a commit that referenced this issue Jun 12, 2024
<!-- disable:changelog-checks -->

# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

Fix #29085

# How

<!--
How did you build this feature or fix this bug and why?
-->

Fix the typo in the `withTransactionAsync(task)` example and update it
to use `getFirstAsync()` method.

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

Changes applied to `unversioned` by running `et gdad -p expo-sqlite`.

Changes applied to SDK 51 API reference by generating source using `et`
command from SDK 51 branch, stashing those changes, and then bringing
the data generated file (expo-sqlite.json) to this branch.


## Preview of updated example


![CleanShot 2024-06-07 at 17 10
32@2x](https://github.com/expo/expo/assets/10234615/4795ca33-d524-4324-965d-7988404dedbb)


# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
marklawlor pushed a commit that referenced this issue Jun 12, 2024
<!-- disable:changelog-checks -->

# Why

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

Fix #29085

# How

<!--
How did you build this feature or fix this bug and why?
-->

Fix the typo in the `withTransactionAsync(task)` example and update it
to use `getFirstAsync()` method.

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

Changes applied to `unversioned` by running `et gdad -p expo-sqlite`.

Changes applied to SDK 51 API reference by generating source using `et`
command from SDK 51 branch, stashing those changes, and then bringing
the data generated file (expo-sqlite.json) to this branch.


## Preview of updated example


![CleanShot 2024-06-07 at 17 10
32@2x](https://github.com/expo/expo/assets/10234615/4795ca33-d524-4324-965d-7988404dedbb)


# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants