Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react-native-netinfo to SDK #3552

Closed
brentvatne opened this issue Feb 21, 2019 · 5 comments
Closed

Add react-native-netinfo to SDK #3552

brentvatne opened this issue Feb 21, 2019 · 5 comments
Assignees
@sjchmiela
Milestone
SDK 33

Comments

@brentvatne
Copy link
Member

https://github.com/react-native-community/react-native-netinfo
@dereknelson dereknelson mentioned this issue Feb 21, 2019
Closed
@matt-oakes
Copy link
Contributor

I might not be the best person to do this as I never use Expo, however, if someone gives me a list of the steps required to do this, then I can try to help out.

@dereknelson
Copy link
Contributor

@brentvatne didn't see this in the roadmap for SDK 33 - just bumping this as there's a pretty critical issue where if you have more than ~5 concurrent fetch requests, they take forever to resolve, if they end up resolving at all.

@brentvatne brentvatne added this to the SDK33 milestone Mar 18, 2019
@brentvatne
Copy link
Member Author

@dereknelson - can you explain? i don't understand how that's related to this issue

@dereknelson
Copy link
Contributor

@brentvatne there's a bug in netinfo that surfaced in SDK 32 which was fixed in the rn-community version of netinfo. I just wanted to make sure it got added in SDK 33 because the bug is severely affecting our user's experience.

@brentvatne
Copy link
Member Author

thanks!

@sjchmiela sjchmiela self-assigned this Mar 19, 2019
@sjchmiela sjchmiela mentioned this issue Mar 19, 2019
Merged
1 task
sjchmiela added a commit that referenced this issue Mar 21, 2019
@sjchmiela
[expo] Add react-native-netinfo (#3783)
a981994 
# Why

Closes #3552.

# How

- added `upgrade-react-native-netinfo` script to `tools`
- ran the script
- added NetInfoScreen to NCL
- updated mocks

# Test Plan

- [x] Test the module in NCL on Android and iOS.
@lock lock bot added the outdated label Sep 17, 2019
@lock lock bot locked and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sjchmiela sjchmiela

Labels
None yet
Projects
None yet
Milestone
SDK 33
Development

No branches or pull requests
4 participants
@brentvatne @matt-oakes @sjchmiela @dereknelson