-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-native-netinfo to SDK #3552
Comments
I might not be the best person to do this as I never use Expo, however, if someone gives me a list of the steps required to do this, then I can try to help out. |
@brentvatne didn't see this in the roadmap for SDK 33 - just bumping this as there's a pretty critical issue where if you have more than ~5 concurrent fetch requests, they take forever to resolve, if they end up resolving at all. |
@dereknelson - can you explain? i don't understand how that's related to this issue |
@brentvatne there's a bug in netinfo that surfaced in SDK 32 which was fixed in the rn-community version of netinfo. I just wanted to make sure it got added in SDK 33 because the bug is severely affecting our user's experience. |
thanks! |
# Why Closes #3552. # How - added `upgrade-react-native-netinfo` script to `tools` - ran the script - added NetInfoScreen to NCL - updated mocks # Test Plan - [x] Test the module in NCL on Android and iOS.
https://github.com/react-native-community/react-native-netinfo
The text was updated successfully, but these errors were encountered: