Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] send CDP type by mime type #23058

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jun 23, 2023

Why

previously we send the CDP request/response type as fetch always. we should send other types like image when the resources are images
close ENG-8609

How

based on mime type to send the corresponding CDP type. for unknown data, we will send other. so we will never send fetch type anymore, because we cannot differentiate whether the requests are coming from fetch or other requests like image or native calls.

Test Plan

  • tested on bare-expo
    Screenshot 2023-06-24 at 12 57 46 AM

  • added unit test

Checklist

@linear
Copy link

linear bot commented Jun 23, 2023

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 23, 2023
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 23, 2023
@Kudo Kudo marked this pull request as ready for review June 23, 2023 17:40
@Kudo Kudo removed the request for review from lukmccall June 23, 2023 17:40
@Kudo Kudo merged commit ea5561f into main Jun 24, 2023
@Kudo Kudo deleted the @kudo/eng-8609-network-inspector-use-image-rather-than-fetch-type-for branch June 24, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants