Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-status-bar] Support animated property for setStatusBarStyle #23408

Merged
merged 3 commits into from
Jul 27, 2023
Merged

[expo-status-bar] Support animated property for setStatusBarStyle #23408

merged 3 commits into from
Jul 27, 2023

Conversation

haikov
Copy link
Contributor

@haikov haikov commented Jul 9, 2023

Why

When using setStatusBarStyle from expo-status-bar I noticed that there is no support for passing animated value which exists in React Native API. Making a quick PR to add the support for it.

How

Added additional boolean property to setStatusBarStyle to match the API with the one from RN core.

Test Plan

I added a new unit tests which verifies that proper value is passed down to RN version of setStatusBarStyle. In addition, I had to update the exiting test with undefined as a second parameter in case if the value for animated is not present.

Checklist

@haikov haikov requested a review from brentvatne as a code owner July 9, 2023 10:43
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 9, 2023
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 9, 2023
@haikov
Copy link
Contributor Author

haikov commented Jul 26, 2023

@brentvatne any chance of getting a review for this one? 🙏

@brentvatne
Copy link
Member

good catch, thanks!

@haikov
Copy link
Contributor Author

haikov commented Jul 27, 2023

Thank you! Synced my fork to get #23741 in, so the CI should be green now. I think it's good to merge now.

@brentvatne brentvatne merged commit 9abe46d into expo:main Jul 27, 2023
7 checks passed
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants