[expo-av] Fix stability issue due to player-item observers not cleaned up #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
bbarthec
approved these changes
Jul 22, 2020
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
…d up (expo#9350) * [expo-av] Cleanup player-item observers * [nlc] Add expo-av replay option * [expo-av] Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There are reports of crashes in the observer handling code of AVPlayerData, see #7764. This PR fixes a problem with AVPlayerItem observers not being removed after the AVQueuePlayer switched to another item.
Together with #9334, this might provide a fix for #7764 but that needs to be verified first.
How
Replayoption to NCL in order to verify existing replay behaviorTest Plan