[expo-av] Fix instability issues when changing source and useNativeControls #9381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
bbarthec
reviewed
Jul 27, 2020
| } | ||
| // Any ViewController/layer updates need to be | ||
| // executed on the main UI thread. | ||
| __weak EXVideoView *weakSelf = self; |
There was a problem hiding this comment.
FYI, we have macros for handling those nasty __weak self references.
Instead of __weak VariableType *var = variable use UM_WEAKIFY(variable)
and instead of __strong ... use UM_STRONGIFY or even UM_ENSURE_STRONGIFY (the latter comes with auto-checking for nullability).
bbarthec
reviewed
Jul 27, 2020
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
…ntrols (expo#9381) * [ncl] Add multiple sources switching for video-player * [expo-av] Fix stability issues when changing source & useNativeControls * [test] Add video tests for changing source & useNativeControls * [expo-av] Update changelog
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #7137. Code that changes the UI is not always executed in the main UI thread, causing immediate or delayed crashes in the EXVideoView. This was reproducible by changing the source icw setting
useNativeControlsto true, however it is not limited to this situation and may occur on other scenarios as well.How
setUseNativeControlsnot checking whether player-load is completeChange source button in NCL
Test Plan