-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snackager] try to fix expo-linear-gradient issue #476
Merged
Kudo
merged 6 commits into
main
from
@kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering
Sep 28, 2023
Merged
[snackager] try to fix expo-linear-gradient issue #476
Kudo
merged 6 commits into
main
from
@kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-10114 [expo-linear-gradient][Android] Linear-gradient rendering incorrectly on Android 13
This issue was automatically imported from GitHub: expo/expo#24424Issue accepted by brentSummary:
|
Kudo
temporarily deployed
to
snackager-staging
September 21, 2023 10:13
— with
GitHub Actions
Inactive
Kudo
temporarily deployed
to
snackager-staging
September 21, 2023 12:55
— with
GitHub Actions
Inactive
Kudo
force-pushed
the
@kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering
branch
from
September 21, 2023 14:47
5577fe3
to
9c3e911
Compare
Kudo
temporarily deployed
to
snackager-staging
September 21, 2023 17:32
— with
GitHub Actions
Inactive
Kudo
force-pushed
the
@kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering
branch
from
September 21, 2023 19:08
770b8b9
to
d27c8a0
Compare
Kudo
force-pushed
the
@kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering
branch
from
September 21, 2023 20:30
8f73db8
to
499e178
Compare
Kudo
temporarily deployed
to
snackager-staging
September 21, 2023 20:33
— with
GitHub Actions
Inactive
Kudo
temporarily deployed
to
runtime-staging
September 22, 2023 07:07
— with
GitHub Actions
Inactive
byCedric
approved these changes
Sep 22, 2023
Kudo
temporarily deployed
to
snackager-staging
September 24, 2023 07:25
— with
GitHub Actions
Inactive
This reverts commit 445f7ae.
Kudo
force-pushed
the
@kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering
branch
from
September 26, 2023 16:04
7392fd5
to
97a4c82
Compare
Kudo
temporarily deployed
to
snackager-staging
September 26, 2023 16:14
— with
GitHub Actions
Inactive
Kudo
temporarily deployed
to
website-staging
September 26, 2023 16:16
— with
GitHub Actions
Inactive
byCedric
approved these changes
Sep 28, 2023
Kudo
deleted the
@kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering
branch
September 28, 2023 18:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo-linear-gradient@12.1.2 on sdk 48 is broken on android: expo/expo#24424
close ENG-10114
How
expo-linear-gradient 12.1.1 <-> 12.1.2 does not change anything from js side. i think the problem is coming from snackager. comparing the two bundles:
i noticed they are slight changes, mostly ESM / CJS difference.
my hypotheses are:
@babel/runtime
expo-modules-core@*
in this case.the solution is passing exact @babel/runtime version to install. that could prevent the inconsistent version between @babel/plugin-transform-runtime and @babel/runtime.
since our @babel/runtime is 7.12.5, we could also use the explicituseESModules
.To fix the expo-modules-core breaking change, now this pr tries to fetch
bundledNativeModules
from api server and install recommended versions accordingly.Test Plan
deploy staging to test the test case from https://staging-snack.expo.dev/@kudochien/linear-gradient. may wait 24 hrs for cloudfront to purge the cache.