Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snackager] try to fix expo-linear-gradient issue #476

Conversation

Kudo
Copy link
Collaborator

@Kudo Kudo commented Sep 20, 2023

Why

expo-linear-gradient@12.1.2 on sdk 48 is broken on android: expo/expo#24424
close ENG-10114

How

expo-linear-gradient 12.1.1 <-> 12.1.2 does not change anything from js side. i think the problem is coming from snackager. comparing the two bundles:

my hypotheses are:

the solution is passing exact @babel/runtime version to install. that could prevent the inconsistent version between @babel/plugin-transform-runtime and @babel/runtime.
since our @babel/runtime is 7.12.5, we could also use the explicit useESModules.
To fix the expo-modules-core breaking change, now this pr tries to fetch bundledNativeModules from api server and install recommended versions accordingly.

Test Plan

deploy staging to test the test case from https://staging-snack.expo.dev/@kudochien/linear-gradient. may wait 24 hrs for cloudfront to purge the cache.

@Kudo Kudo requested a review from byCedric as a code owner September 20, 2023 16:06
@linear
Copy link

linear bot commented Sep 20, 2023

ENG-10114 [expo-linear-gradient][Android] Linear-gradient rendering incorrectly on Android 13

This issue was automatically imported from GitHub: expo/expo#24424

Issue accepted by brent


Summary:

  • The user is having an issue with gradients not working on Android in the current version of Expo.
  • This issue can be reproduced using the snack provided in the ExpoLinearGradient section of the Expo docs.
  • The gradients seem to work as expected on iOS, but not on Android as is highlighted with the screenshots the user provided.
  • The user created a minimal reproducible example available at a provided GitHub link.
  • The underlying issue is not specified, so further investigation will be required to determine the cause for this unexpected behavior.

@Kudo Kudo marked this pull request as draft September 20, 2023 16:44
@Kudo Kudo temporarily deployed to snackager-staging September 21, 2023 10:13 — with GitHub Actions Inactive
@Kudo Kudo temporarily deployed to snackager-staging September 21, 2023 12:55 — with GitHub Actions Inactive
@Kudo Kudo force-pushed the @kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering branch from 5577fe3 to 9c3e911 Compare September 21, 2023 14:47
@Kudo Kudo temporarily deployed to snackager-staging September 21, 2023 17:32 — with GitHub Actions Inactive
@Kudo Kudo force-pushed the @kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering branch from 770b8b9 to d27c8a0 Compare September 21, 2023 19:08
@Kudo Kudo force-pushed the @kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering branch from 8f73db8 to 499e178 Compare September 21, 2023 20:30
@Kudo Kudo temporarily deployed to snackager-staging September 21, 2023 20:33 — with GitHub Actions Inactive
@Kudo Kudo temporarily deployed to runtime-staging September 22, 2023 07:07 — with GitHub Actions Inactive
@Kudo Kudo marked this pull request as ready for review September 22, 2023 07:50
@Kudo Kudo temporarily deployed to snackager-staging September 24, 2023 07:25 — with GitHub Actions Inactive
@Kudo Kudo force-pushed the @kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering branch from 7392fd5 to 97a4c82 Compare September 26, 2023 16:04
@Kudo Kudo temporarily deployed to snackager-staging September 26, 2023 16:14 — with GitHub Actions Inactive
@Kudo Kudo temporarily deployed to website-staging September 26, 2023 16:16 — with GitHub Actions Inactive
@Kudo Kudo merged commit 6df5443 into main Sep 28, 2023
28 checks passed
@Kudo Kudo deleted the @kudo/eng-10114-expo-linear-gradientandroid-linear-gradient-rendering branch September 28, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants