Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow token to be a promise and use built-in .json() method #20

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Allow token to be a promise and use built-in .json() method #20

merged 1 commit into from
Sep 28, 2017

Conversation

altwohill
Copy link
Contributor

This fixes the issue described in #19

@jeff-da
Copy link
Contributor

jeff-da commented Sep 28, 2017

Looks good, thanks!

@jeff-da jeff-da merged commit c917a32 into expo:master Sep 28, 2017
@cjbutcher cjbutcher mentioned this pull request Apr 23, 2018
Closed
@slorber
Copy link

slorber commented Apr 25, 2018 •
edited
Loading

please publish this fix on npm as current version 1.1.3 seems to fail due to json parsing errors and does not include that fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altwohill @jeff-da @slorber