-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable comparison feature like python #664
Conversation
Expr already has chained comp operation (#581)
One issue we encountered with implementing Python style ComparisonNode is backward comp. In Expr next expressions parsed as left:
So implementing I think those comparison should cover much of the requirements. Also I think allowing to use
@bizywizy may remember more. |
Yes, I think it's too late to change this behaviour
|
This change won`t affect expr functionality but it will use the functionality like python
|
The == and != operators function based on the right-hand expression. If the right-hand expression is a boolean, the left-hand expression will be evaluated as a boolean. Ex : 30 > 19 in 18..31 != true
|
Then I don't understand what this PR tries to implement. What's different? |
This PR supports all comparison operators(>, >=, <, <=, in, !=, ==, in, matches, contains, startsWith, endsWith) in chained comparison operations. |
But why? |
This pull request adds support for a comparison feature similar to Python.