Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coveralls badge and typo in README.md #30

Closed
wants to merge 1 commit into from
Closed

Fixed coveralls badge and typo in README.md #30

wants to merge 1 commit into from

Conversation

ifraixedes
Copy link

No description provided.

@dougwilson
Copy link
Contributor

I am already using the correct coveralls badge, the service just seems to be down. You changed it from SVG to a PNG one, which looks like garbage on high DPI displays.

@dougwilson dougwilson closed this Jun 20, 2014
@ifraixedes
Copy link
Author

Ok, What about the typo? do I only send it?

@dougwilson
Copy link
Contributor

I fixed the typo in the readme, thank you :)

@ifraixedes
Copy link
Author

Your are welcome, at the end is the think that I wanted to report, by I though that the badge was wrong, for that reason I changed it, my apologies for that.

Thanks.

@dougwilson
Copy link
Contributor

It's no problem. I did not know the reasoning behind the badge change. At first I was thinking you changed it because I had it pointing to the wrong repo :)

@dougwilson dougwilson added the pr label Jul 20, 2014
@expressjs expressjs locked and limited conversation to collaborators Jul 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants