fixes #120 - content length zero for 204 response #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dougwilson
suggested changes
Jul 12, 2017
benjamine
force-pushed
the
feature/content-length-zero
branch
2 times, most recently
from
a3775fd
to
fa206f3
Compare
Safari apparently hangs waiting for the body when OPTIONS response is 204, content-length: 0 fixes that behavior.
|
thanks @dougwilson, I made those changes (added 1 test case for this, seems fine for the change but let me know if I'm missing conditions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari apparently hangs waiting for the body when OPTIONS response is
204, content-length: 0 fixes that behavior.