Adding verification that sess.cookie is set

session/session.js

@@ -92,8 +92,12 @@ defineMethod(Session.prototype, 'reload', function reload(fn) {
   store.get(this.id, function(err, sess){
     if (err) return fn(err);
     if (!sess) return fn(new Error('failed to load session'));
-    store.createSession(req, sess);
-    fn();
+    try {
+      store.createSession(req, sess);
+    } catch (e) {
+      err = e
+    }
+    fn(err);
   });
   return this;
 });

session/store.js

@@ -70,7 +70,13 @@ Store.prototype.load = function(sid, fn){
     if (err) return fn(err);
     if (!sess) return fn();
     var req = { sessionID: sid, sessionStore: self };
-    fn(null, self.createSession(req, sess))
+    try {
+      sess = self.createSession(req, sess)
+    } catch (e) {
+      err = e
+      sess = null
+    }
+    fn(err, sess)
   });
 };
 

test/session.js

@@ -490,6 +490,35 @@ describe('session()', function(){
     })
   })
 
+  describe('when session is corrupt', function () {
+    it('should return an error', function (done) {
+      var store = new session.MemoryStore()
+      var server = createServer({ store: store }, function (req, res) {
+        req.session.count = req.session.count || 0
+        req.session.count++
+        res.end('hits: ' + req.session.count)
+      })
+
+      store.get = function returnCorruptSession(sid, callback) {
+        callback(undefined, {});
+      }
+
+      request(server)
+      .get('/')
+      .expect(200, 'hits: 1', function (err, res) {
+        if (err) return done(err)
+        store.load(sid(res), function (err, sess) {
+          assert.ok(err);
+          assert.ok(err.message.match(/Cannot read prop/));
+          request(server)
+          .get('/')
+          .set('Cookie', cookie(res))
+          .expect(500, /Cannot read prop/, done)
+        })
+      })
+    })
+  })
+
   describe('when session expired in store', function () {
     it('should create a new session', function (done) {
       var count = 0
@@ -1665,6 +1694,40 @@ describe('session()', function(){
         })
       })
 
+      it('should error when the session is corrupt', function (done) {
+        var store = new session.MemoryStore()
+        var server = createServer({ store: store }, function (req, res) {
+          if (req.url === '/') {
+            req.session.active = true
+            res.end('session created')
+            return
+          }
+
+          store.clear(function (err) {
+            if (err) return done(err)
+
+            store.get = function returnCorruptSession(sid, callback) {
+              callback(undefined, {});
+            }
+
+            req.session.reload(function (err) {
+              res.statusCode = err ? 500 : 200
+              res.end(err ? err.message : '')
+            })
+          })
+        })
+
+        request(server)
+        .get('/')
+        .expect(200, 'session created', function (err, res) {
+          if (err) return done(err)
+          request(server)
+          .get('/foo')
+          .set('Cookie', cookie(res))
+          .expect(500, /Cannot read prop/, done)
+        })
+      })
+
       it('should not override an overriden `reload` in case of errors',  function (done) {
         var store = new session.MemoryStore()
         var server = createServer({ store: store, resave: false }, function (req, res) {