-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(babel-preset-app): add support for core-js 3 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exreplay
changed the title
feat(babel-preset-app): update to core-js 3
feat(babel-preset-app): add support core-js 3
Jul 20, 2019
exreplay
changed the title
feat(babel-preset-app): add support core-js 3
feat(babel-preset-app): add support for core-js 3
Jul 20, 2019
Codecov Report
@@ Coverage Diff @@
## development #74 +/- ##
===============================================
- Coverage 100% 98.94% -1.06%
===============================================
Files 16 20 +4
Lines 156 189 +33
Branches 18 24 +6
===============================================
+ Hits 156 187 +31
- Misses 0 1 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is currently unstable. The problem is that a lot of dependencies are currently still using
core-js 2
and if the user not explicitly installscore-js 3
, modules are not resolved correctly.UPDATE 30.12.19
The support is now given but if the user wants to use
core-js 3
the packages have to be installed in the root of the project. Aver still has version 2 installed internally to prevent projects from breaking.