Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel-preset-app): add support for core-js 3 #74

Merged
merged 35 commits into from
Dec 30, 2019

Conversation

exreplay
Copy link
Owner

@exreplay exreplay commented Jul 7, 2019

This feature is currently unstable. The problem is that a lot of dependencies are currently still using core-js 2 and if the user not explicitly installs core-js 3, modules are not resolved correctly.

UPDATE 30.12.19
The support is now given but if the user wants to use core-js 3 the packages have to be installed in the root of the project. Aver still has version 2 installed internally to prevent projects from breaking.

@exreplay exreplay changed the title feat(babel-preset-app): update to core-js 3 feat(babel-preset-app): add support core-js 3 Jul 20, 2019
@exreplay exreplay changed the title feat(babel-preset-app): add support core-js 3 feat(babel-preset-app): add support for core-js 3 Jul 20, 2019
@codecov
Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #74 into development will decrease coverage by 1.05%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #74      +/-   ##
===============================================
- Coverage          100%   98.94%   -1.06%     
===============================================
  Files               16       20       +4     
  Lines              156      189      +33     
  Branches            18       24       +6     
===============================================
+ Hits               156      187      +31     
- Misses               0        1       +1     
- Partials             0        1       +1
Impacted Files Coverage Δ
packages/config/lib/configs/renderer.js 100% <ø> (ø) ⬆️
packages/babel-preset-app/lib/getPolyfills.js 100% <100%> (ø)
packages/babel-preset-app/lib/index.js 100% <100%> (ø)
packages/babel-preset-app/lib/polyfillsPlugin.js 80% <0%> (ø)
babel.config.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1c545...286df45. Read the comment docs.

@exreplay exreplay merged commit a4c88ef into development Dec 30, 2019
@exreplay exreplay deleted the feat/babel-preset-app-core-js-3 branch December 30, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant