Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump jest peer dependency #10

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

mattcasey
Copy link
Contributor

@mattcasey mattcasey commented Apr 23, 2021

Community guidelines:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • [x ] other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • [x ] no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • [x ] no

Description

This package relies on conflicting versions of jest between its devDependencies (v26) and peerDependencies (v24). Since npm 7, peer dependencies that conflict will now throw an error when you try to install the package. I'm not sure but I think it was accidentally downgraded in this commit 34602dd#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L79.

To reproduce the error, run:

  npm install jest@26 jest-chrome

Error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: test@1.0.0
npm ERR! Found: jest@26.6.3
npm ERR! node_modules/jest
npm ERR!   jest@"^26.6.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^24.9.0" from jest-chrome@0.7.0
npm ERR! node_modules/jest-chrome
npm ERR!   jest-chrome@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@jacksteamdev jacksteamdev merged commit 11b6a09 into extend-chrome:master Apr 29, 2021
@jacksteamdev
Copy link
Contributor

@mattcasey Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants