Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added optimisations to Cargo.toml #226

Closed
wants to merge 1 commit into from
Closed

added optimisations to Cargo.toml #226

wants to merge 1 commit into from

Conversation

alexhroom
Copy link

@alexhroom alexhroom commented Jan 5, 2023

Adds some compiler optimisations to Cargo.toml. This should remove the R CMD CHECK NOTE on the compiled code being very large.

@CGMossa
Copy link
Member

CGMossa commented Jan 5, 2023

We have generally decided against this. The gains vs. drawbacks are not the same for every use-case. See this issue for more as to how we decided on this: #173 #173

@CGMossa CGMossa closed this Jan 5, 2023
@alexhroom
Copy link
Author

@CGMossa will create an issue on this topic instead (at @Ilia-Kosenkov's suggestion on discord)- it isn't the same issue as #173 especially now CRAN is more relevant than it was previously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants