Rework features param in rust_source()
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ilia-Kosenkov
changed the title
features param in rust_source()features param in rust_source()
CGMossa
reviewed
Mar 6, 2023
multimeric
requested changes
Mar 6, 2023
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
|
Please rename the example that doesn't contain either, to something without either. |
CGMossa
reviewed
Mar 6, 2023
CGMossa
approved these changes
Mar 6, 2023
Co-authored-by: CGMossa <cgmossa@gmail.com>
multimeric
approved these changes
Mar 7, 2023
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general improvement of
rust_source().extendr_depsanddependenciesto be named listsextendr_depsintodependencies-- ifdependenciescontainsextendr-apientry, it will be overwritten by that ofextendr_depsfeaturesa feature flag variable, allowing"ndarray", "num-complex", "serde", "graphics"features (and their combinations)featuresproperty onextendr-apino matter how it is definedgraphicsFixed #239