Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extendr_fn_options parameter to rust_function() #252

Merged
merged 28 commits into from
Mar 25, 2023
Merged

Add extendr_fn_options parameter to rust_function() #252

merged 28 commits into from
Mar 25, 2023

Conversation

Ilia-Kosenkov
Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov commented Mar 8, 2023 •
edited
Loading

  • Add extendr_fn_options (better name?) to rust_function(), which accepts a named list of scalar values, each translating to an option passed to #[extendr] attribute.
  • Maintain a list of known options, such as use_try_from, r_name, mod_name.
  • Raise warnings on unknown options.
  • Verify types of known options
  • Abort if type mismatch, if an option has NULL value, or if the name is malformed.

Closes #131

@Ilia-Kosenkov Ilia-Kosenkov changed the title Add extendr_fn_options parameter to rust_source() Add extendr_fn_options parameter to rust_function() Mar 8, 2023
@Ilia-Kosenkov Ilia-Kosenkov marked this pull request as ready for review March 8, 2023 21:38
multimeric
multimeric requested changes Mar 12, 2023
View reviewed changes
R/function_options.R Outdated Show resolved Hide resolved
R/function_options.R Show resolved Hide resolved
R/function_options.R Outdated Show resolved Hide resolved
multimeric
multimeric requested changes Mar 20, 2023
View reviewed changes
R/function_options.R Outdated Show resolved Hide resolved
R/function_options.R Outdated Show resolved Hide resolved
R/function_options.R Outdated Show resolved Hide resolved
R/function_options.R Outdated Show resolved Hide resolved
@Ilia-Kosenkov @multimeric
Update R/function_options.R
5d530ef 
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
@Ilia-Kosenkov
Revert "Use rows_update"
7c44885 
This reverts commit 898f180.
multimeric
multimeric approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@multimeric multimeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some very good tests too.

tests/testthat/test-extendr_function_options.R Outdated Show resolved Hide resolved
tests/testthat/test-extendr_function_options.R Outdated Show resolved Hide resolved
Ilia-Kosenkov and others added 2 commits March 25, 2023 01:59
@Ilia-Kosenkov @multimeric
Update tests/testthat/test-extendr_function_options.R
e08f1af 
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
@Ilia-Kosenkov @multimeric
Update tests/testthat/test-extendr_function_options.R
94d8dbd 
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
@Ilia-Kosenkov Ilia-Kosenkov merged commit fc3c70d into extendr:main Mar 25, 2023
@Ilia-Kosenkov Ilia-Kosenkov mentioned this pull request Mar 25, 2023
Closed
@Ilia-Kosenkov Ilia-Kosenkov deleted the feature/Support-extendr-options-in-rust_function branch September 24, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multimeric multimeric multimeric approved these changes

@CGMossa CGMossa Awaiting requested review from CGMossa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support extendr options in rust_function()
2 participants
@Ilia-Kosenkov @multimeric